vine: daskvine priority scheduling #3923
Conversation
| return dependencies | ||
|
|
||
| def set_depth(self, key): |
There was a problem hiding this comment.
I'm not sure about this change. Didn't the old way of computing depth worked?
There was a problem hiding this comment.
@btovar No, the old way didn't give me the right depth.
There was a problem hiding this comment.
In which way it didn't work? Do you have an example? Is it a different definition of graph depth?
There was a problem hiding this comment.
I tested it about 2 months ago, my impression is that the depth of every task in the graph was always 0 or 1 or something fixed, and then I just wrote a new function to calculate the depth.
There was a problem hiding this comment.
It did work for me when I was testing checkpoints. Please check again because it may indicate that something else in the code broke. Also, it is a much easier code to follow, which may help with dealing with future bugs.
taskvine/src/bindings/python3/ndcctools/taskvine/dask_executor.py
Outdated
Show resolved
Hide resolved
|
I reverted |
|
Sounds good, thanks! |
Proposed Changes
Give an overall description of the changes, along with the context and motivation.
Mention relevant issues and pull requests as needed.
Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.